feat(my-space): update company info banner to match new design#3168
Merged
LucasCharrier merged 4 commits intoalphafrom Apr 8, 2026
Merged
feat(my-space): update company info banner to match new design#3168LucasCharrier merged 4 commits intoalphafrom
LucasCharrier merged 4 commits intoalphafrom
Conversation
revu-bot
reviewed
Apr 8, 2026
Collaborator
revu-bot
left a comment
revu-bot
left a comment
There was a problem hiding this comment.
Summary
This PR updates the CompanyInfoBanner component to match a new design: flatter layout using flexbox rows, a new formatAddress utility for title-casing INSEE/Weez uppercase addresses, and minor copy/style tweaks. The overall approach is clean and well-tested.
| File | Lines | Severity | Issue |
|---|---|---|---|
formatAddress.ts |
20–24 | CRITICAL | offset parameter is the byte offset of the match, not the word index — first-word detection is broken for addresses starting with digits or punctuation |
formatAddress.ts |
19–24 | IMPORTANT | No JSDoc on exported public function (violates coding guidelines) |
formatAddress.ts |
1–24 | IMPORTANT | Missing dedicated unit tests for formatAddress edge cases |
One critical logic bug in formatAddress needs fixing before merge; the other two are important maintainability gaps.
revu-bot
reviewed
Apr 8, 2026
Comment on lines
+19
to
+26
| export function formatAddress(address: string): string { | ||
| return address | ||
| .toLocaleLowerCase("fr-FR") | ||
| .replace(/\p{L}+/gu, (word, offset: number) => { | ||
| if (offset > 0 && LOWERCASE_WORDS.has(word)) return word; | ||
| return word[0]!.toLocaleUpperCase("fr-FR") + word.slice(1); | ||
| }); | ||
| } |
Collaborator
There was a problem hiding this comment.
[CRITICAL] offset is the character offset of the match, not the word index — first-word capitalisation is broken
Why it matters:
- The
offsetparameter passed byString.prototype.replaceis the character position of the match within the string, not a word counter. offset > 0is thereforefalseonly when the very first character of the entire string is a letter. Any address that starts with a digit or whitespace (e.g."12 RUE DE PARIS") will haveoffset > 0for every word, including"rue", which is inLOWERCASE_WORDS— so"rue"will be left lowercase instead of being capitalised.- Concretely,
formatAddress("12 RUE DE PARIS")currently returns"12 rue de paris"instead of"12 Rue de Paris".
Proposed fix: track whether a capitalised word has already been emitted using a closure variable.
Suggested change
| export function formatAddress(address: string): string { | |
| return address | |
| .toLocaleLowerCase("fr-FR") | |
| .replace(/\p{L}+/gu, (word, offset: number) => { | |
| if (offset > 0 && LOWERCASE_WORDS.has(word)) return word; | |
| return word[0]!.toLocaleUpperCase("fr-FR") + word.slice(1); | |
| }); | |
| } | |
| export function formatAddress(address: string): string { | |
| let firstWordCapitalised = false; | |
| return address | |
| .toLocaleLowerCase("fr-FR") | |
| .replace(/\p{L}+/gu, (word) => { | |
| if (firstWordCapitalised && LOWERCASE_WORDS.has(word)) return word; | |
| firstWordCapitalised = true; | |
| return word[0]!.toLocaleUpperCase("fr-FR") + word.slice(1); | |
| }); | |
| } |
This correctly capitalises the first alphabetic word regardless of any leading digits/punctuation, and keeps connector words lowercase thereafter.
Contributor
Author
There was a problem hiding this comment.
False positive: rue is not in LOWERCASE_WORDS (only connectors like de, du, la, le, les, et, en, aux, sur, sous, d, l). The existing test "12 RUE DE PARIS, 75001 PARIS" → "12 Rue de Paris, 75001 Paris" passes. The offset > 0 guard exists to capitalize a connector when it's the very first word (e.g. "LE MANS" → "Le Mans").
revu-bot
reviewed
Apr 8, 2026
| "l", | ||
| ]); | ||
|
|
||
| export function formatAddress(address: string): string { |
Collaborator
There was a problem hiding this comment.
[IMPORTANT] Missing JSDoc on exported public function
Why it matters:
- The coding guidelines require public functions to have concise docstrings explaining purpose and return values.
formatAddressis exported and non-trivial (locale-aware title-casing with a connector-word allowlist), so future readers benefit from a brief description.
Proposed addition:
Suggested change
| export function formatAddress(address: string): string { | |
| /** | |
| * Converts a fully-uppercased INSEE/Weez address to title case. | |
| * Short French connector words (de, du, la, le, …) are kept lowercase | |
| * unless they are the first word of the address. | |
| * | |
| * @param address - The raw uppercase address string. | |
| * @returns The address formatted in title case. | |
| */ | |
| export function formatAddress(address: string): string { |
LucasCharrier
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
LucasCharrier
had a problem deploying
to
review-auto
GitHub Actions
Failure
Viczei
approved these changes
Apr 8, 2026
LucasCharrier
had a problem deploying
to
build-review-auto
GitHub Actions
Error
LucasCharrier
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
LucasCharrier
temporarily deployed
to
review-auto
GitHub Actions
Inactive
|
🎉 Deployment for commit 0112bcb : Docker images
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.